pull request for atomic

[Gedare Bloom]

I have made some comments on your new version. If you have further
questions or answers to any questions I put please send an email I am
more likely to see it.

-Gedare

On Wed, Jul 25, 2012 at 2:00 AM,  <wei.a.yang at gmail.com> wrote:
>
> 在 2012-7-25，2:42，Gedare Bloom <gedare at rtems.org> 写道：
>
>> On Tue, Jul 24, 2012 at 12:29 PM, yangwei weiyang <wei.a.yang at gmail.com> wrote:
>>> 2012/7/23 Gedare Bloom <gedare at rtems.org>:
>>>> On Mon, Jul 23, 2012 at 4:45 AM, yangwei weiyang <wei.a.yang at gmail.com> wrote:
>>>>> 2012/7/23 Sebastian Huber <sebastian.huber at embedded-brains.de>:
>>>>>> Hi,
>>>>>>
>>>>>> is it possible to squash the commits together?  This makes it easier to
>>>>>> review.
>>>>> Hi Sebastian, firstly thank you for your comments. The commits are a
>>>>> little trivial because all commits are submitted step by step. And i
>>>>> do not know how to make a pull request on github with a single patch
>>>>> from first commit to last commit. Or i can generate a patch manually
>>>>> and send it to mail list.
>>>>
>>>> git rebase -i
>>>>
>>>> should let you specify revision range and squash commits together.
>>>> then you can push a new branch and make new request.
>>> Hi Gedare, Could you tell me more details about this command.
>>> I use git rebase master atomic but all commits do not squash together.
>>
>> http://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits
> Hi Gedare. Thank you for your material, it is very useful for me. And I have squash all the commits and create a new branch atomic-review to pull request. Any comments are welcome.
>>
>>>>
>>>>>>
>>>>>> Since you wrote the files probably on your own they should have your
>>>>>> copyright.
>>>>>>
>>>>> OK, i will add the copyright to the appropriate files.
>>>>>> The file "cpukit/score/cpu/i386/rtems/score/atomic_cpu.h" should include a
>>>>>> generic file e.g. "cpukit/score/include/rtems/score/genericcpuatomic.h" with
>>>>>> the type definitions.  I think we can use this generic file on every CPU
>>>>>> port.
>>>>>>
>>>>> Yeah, agree. And RTEMS support so many architectures so i will think
>>>>> about what types should be generic to all cpu architecture.
>>>>>> I suggest to use the following type names:
>>>>>>
>>>>>> Atomic_Int
>>>>>> Atomic_Long
>>>>>> Atomic_Int32
>>>>>> Atomic_Int64
>>>>>> Atomic_Pointer
>>>>>>
>>>>> OK. and which file follow this rule that i can study the name rule on RTEMS?
>>>>>> I suggest to rename "atomic_cpu.h" into "cpuatomic.h".  Currently there is
>>>>>> no header file in the score with a "_".
>>>>>>
>>>>> OK.
>>>>>>
>>>>>> On 07/22/2012 06:08 PM, yangwei weiyang wrote:
>>>>>>>
>>>>>>> Hi all,
>>>>>>>
>>>>>>> I have made a pull request for review the source code of atomic, and
>>>>>>> could you give me any comments? thank you!
>>>>>>>
>>>>>>> pull request link is blow:
>>>>>>> https://github.com/RTEMS/rtems/pull/1
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Sebastian Huber, embedded brains GmbH
>>>>>>
>>>>>> Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
>>>>>> Phone   : +49 89 18 90 80 79-6
>>>>>> Fax     : +49 89 18 90 80 79-9
>>>>>> E-Mail  : sebastian.huber at embedded-brains.de
>>>>>> PGP     : Public key available on request.
>>>>>>
>>>>>> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> rtems-devel mailing list
>>>>>> rtems-devel at rtems.org
>>>>>> http://www.rtems.org/mailman/listinfo/rtems-devel
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Wei Yang
>>>>> Best Regards
>>>>>
>>>>> wei.a.yang at gmail.com
>>>>>
>>>>> _______________________________________________
>>>>> rtems-devel mailing list
>>>>> rtems-devel at rtems.org
>>>>> http://www.rtems.org/mailman/listinfo/rtems-devel
>>>
>>>
>>>
>>> --
>>> Wei Yang
>>> Best Regards
>>>
>>> wei.a.yang at gmail.com