[PATCH] Reference counting for file system locations

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Mar 1 14:54:50 UTC 2012


On 03/01/2012 03:46 PM, Gedare Bloom wrote:
> On Thu, Mar 1, 2012 at 8:25 AM, Sebastian Huber
> <sebastian.huber at embedded-brains.de>  wrote:
[...]
>>>>> +++ b/cpukit/libcsupport/src/freenode.c
>>>>> +void rtems_filesystem_freenode( rtems_filesystem_location_info_t *node
>>>>> )
>>>>> Might be worth calling this rtems_filesystem_location_free()?
>>>>
>>>>
>>>>
>>>> Hm, this name is historic.  Not sure.
>>>>
>>> Maybe someone else can chime in, or we can bring it up later. Seems
>>> like we could unify the naming to replace the idea of a filesystem
>>> 'node' with a filesystem location.
>>
>>
>> Fixed.
>>
> Should we rename the files freenode.c and clonenode.c or maybe even
> move these functions into sup_fs_location.c?
>
> There are also a few residual places where handlers use
> clonenode/freenode as part of their name; I am unsure whether it is
> better to have the freenode/clonenode names on these handlers or not,
> since the function pointer in the op table is still called
> freenod_h/clonenod_h. However, the argument to those functions is a
> filesystem location so I think it makes sense, and we should consider
> renaming freenod_h/clonenod_h---although they are consistent with
> other function handlers like mknod_h/rmnod_h so I don't know. Renaming
> these two functions may have opened a can of worms.

I ignore this can of worms and leave it as it is now ;-)

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list