[PATCH 1/3] Filesystem: PR1398: Fix lseek() mechanic

Sebastian Huber sebastian.huber at embedded-brains.de
Tue May 8 19:17:13 UTC 2012


On 08/05/12 08:43, Chris Johns wrote:
> On 8/05/12 3:34 PM, Sebastian Huber wrote:
>>
>> Is the complex rtems_rfs_rtems_file_lseek() really necessary? What
>> happens if we simply change the iop->offset? Will the read and write
>> handler cope with that?
>>
>
> I do not know. The current file seek code plays with buffers. I am not 
> sure what effect this may have if the code was removed. I can see 
> moving this code would make the seek cheaper and if someone is seeking 
> with no I/O there is a cost.
>
> Is there another issue I am missing ?

I only wondered why the [PATCH 2/3] Filesystem: PR1871: Fix O_APPEND 
works (mrfs_fsrdwr test case).

-- 
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list