[PATCH 1/4] score/scheduling: Use RBTree_First instead of Peek in EDF scheduler.

[Gedare Bloom]

Probably. I'd prefer to deal with style issues separately.

On Wed, May 2, 2012 at 12:56 PM, Joel Sherrill
<joel.sherrill at oarcorp.com> wrote:
> I know we don't have style rules on this case but
> would the code read better to have simple
> variable declarations followed by the logic?
>
>
> On 05/02/2012 11:34 AM, Gedare Bloom wrote:
>>
>> ---
>>  cpukit/score/src/scheduleredfschedule.c |    9 +++------
>>  1 files changed, 3 insertions(+), 6 deletions(-)
>>
>> diff --git a/cpukit/score/src/scheduleredfschedule.c
>> b/cpukit/score/src/scheduleredfschedule.c
>> index 1482be8..a45aca4 100644
>> --- a/cpukit/score/src/scheduleredfschedule.c
>> +++ b/cpukit/score/src/scheduleredfschedule.c
>> @@ -1,12 +1,10 @@
>>  /*
>>   *  Copyright (C) 2011 Petr Benes.
>> - *  Copyright (C) 2011 On-Line Applications Research Corporation (OAR).
>> + *  Copyright (C) 2011-2012 On-Line Applications Research Corporation
>> (OAR).
>>   *
>>   *  The license and distribution terms for this file may be
>>   *  found in the file LICENSE in this distribution or at
>>   *  http://www.rtems.com/license/LICENSE.
>> - *
>> - *  $Id$
>>   */
>>
>>  #if HAVE_CONFIG_H
>> @@ -19,10 +17,9 @@
>>
>>  void _Scheduler_EDF_Schedule(void)
>>  {
>> -  RBTree_Node *first_node =
>> -    _RBTree_Peek(&_Scheduler_EDF_Ready_queue, RBT_LEFT);
>> +  RBTree_Node *first = _RBTree_First(&_Scheduler_EDF_Ready_queue,
>> RBT_LEFT);
>>    Scheduler_EDF_Per_thread *sched_info =
>> -    _RBTree_Container_of(first_node, Scheduler_EDF_Per_thread, Node);
>> +    _RBTree_Container_of(first, Scheduler_EDF_Per_thread, Node);
>>
>>    _Thread_Heir = (Thread_Control *) sched_info->thread;
>>  }
>
>
>
> --
> Joel Sherrill, Ph.D.             Director of Research&   Development
> joel.sherrill at OARcorp.com        On-Line Applications Research
> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
>    Support Available             (256) 722-9985
>
>