Generated files in Git

[Gedare Bloom]

On Wed, May 16, 2012 at 9:33 AM, Ralf Corsepius
<ralf.corsepius at rtems.org> wrote:
> On 05/16/2012 12:35 PM, Sebastian Huber wrote:
>>
>> Hello,
>>
>> we have found some files that are generated during build, and thus
>> should not be under configuration management (CM).
>>
>> If you put the RTEMS source tree under CM with for example Rational
>> Synergy, then this leads to problems.
>>
>> So, when trying to build from a Rational Synergy work area, which by
>> default is
>> write protected, we get some errors. There are .c files, that are
>> generated by
>> running sed on a .in file, but that fails because the generated files
>> were in
>> the original Git repository, and thus migrated into Synergy. Actually
>> only the
>> Makefile.am and the .in should be under CM.
>>
>> As you know, there are two flavours of CM systems, CVS style
>> (modify-commit)
>> and RCS style (lock-modify-commit). Synergy is “RCS style”, while Git is
>> CVS
>> style. That is why we have bigger problems with this inconsistency.
>>
>> The “wrong” files are
>>
>> - 3 .c files in rtems/testsuites/libtests/complex/
>>
>> - 1 .c file in rtems/testsuites/libtests/math/
>>
>> - 1 .c file in rtems/testsuites/libtests/mathf/
>>
>> - 1 .c file in rtems/testsuites/libtests/mathl/
>>
>> Also, the Makefile does not clean the generated files on “make distclean”.
>>
>> How to fix this? Remove the generated files from Git and add a distclean
>> hook?
>
>
> Definitely no. Similar to Makefile.ins, bspopts.h.in, rpcgen-generted files,
> files are generated sources and should be part of the VCS.
>
I disagree that generated files should be under version control. I
think they dilute real changes. But we could have a debate about it.

I noticed that Ralf recently added some generated files to VC / git.
Was there a reason for it? They were also added to 4.10 branch without
discussion or release note updates [1].

[1] http://git.rtems.org/rtems/commit/?h=4.10&id=f29ab47c93619c705c82d096c6d2cb85e95247ba

> Ralf
>
>
>
>
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel