[rtems commit] score: Add RTEMS_FATAL_SOURCE_APPLICATION

[Chris Johns]

Sebastian Huber wrote:
>
> score: Add RTEMS_FATAL_SOURCE_APPLICATION
>

This seems wrong because the file is ...

>   cpukit/score/include/rtems/score/interr.h

.. and that name means internal error and ...

> +   * @brief Fatal source for application specific errors.
> +   *
> +   * The fatal code is application specific.
> +   */
> +  RTEMS_FATAL_SOURCE_APPLICATION,
> +

adding application or non-internal errors to the Internal_errors_Source enum seems wrong.

Why are you adding non-internal errors to the internal error list ?

What is the use case ?

The same goes for the other additions.

Also the comment in the doxygen section of the file states ...

 *  This handler encapsulates functionality which provides the foundation
 *  Semaphore services used in all of the APIs supported by RTEMS.

.. which is a little confusing for an internal header file. Cut and paste error in the past ?

Chris