[rtems commit] bsps/sparc: Add BSP_INITIAL_EXTENSION to <bsp.h>

Chris Johns chrisj at rtems.org
Fri Nov 16 08:32:56 UTC 2012


Sebastian Huber wrote:
> On 11/15/2012 09:37 PM, Chris Johns wrote:
>> Sebastian Huber wrote:
>>> +++ b/c/src/lib/libbsp/sparc/shared/startup/bspfatalextension.c
>>
>> Not an score or even cpukit header yet is references ...
>>
>>> + Internal_errors_Source source,
>>
>> ... which is defined internally.
>
> This problem is present since day one of the user extensions.

Yes I checked after posting and found this is the case. It does not make 
it ok nor specifically your problem.

> Due to that I added
>
> http://git.rtems.org/rtems/commit/?id=e4b40531f3c4b9a6c12be10cc18a9d0f84570230
>

I noticed and this is a good move. It was just the order I reviewed the 
patches.

>
>>
>> This should not be done this way. Looks like we need an external
>> interface to
>> guard the score internals.
>
> In this case this will not help since this enum is part of the public
> interface.
>

Yes. I created a bug to capture this issue.

Given the fact this is part of the C User manual the patches are fine.

Chris



More information about the devel mailing list