[PATCH 01/23] sapi: Use rtems_config*_get_microseconds_per_tick

Joel Sherrill joel.sherrill at OARcorp.com
Tue Nov 6 16:41:47 UTC 2012


That isn't particularly controversial and was actually something I started down the road to when I eliminated BSP_Configuration a few years ago.

I assume you have been building a lot and will ping me for a coverage run soon. :)

--joel

Sebastian Huber <sebastian.huber at embedded-brains.de> wrote:

>On 11/06/2012 04:25 PM, Gedare Bloom wrote:
>> Can you provide some background on this patch series?
>
>Most of them are simple clean-ups.  The important (and potentially 
>controversial) change is the last one:
>
>The Configuration is now read-only and must be statically initialized
>via confdefs.h or similar.
>---
>  cpukit/sapi/include/confdefs.h     |    2 +-
>  cpukit/sapi/include/rtems/config.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/cpukit/sapi/include/confdefs.h b/cpukit/sapi/include/confdefs.h
>index 17cb2ee..00ba59b 100644
>--- a/cpukit/sapi/include/confdefs.h
>+++ b/cpukit/sapi/include/confdefs.h
>@@ -2316,7 +2316,7 @@ rtems_fs_init_functions_t    rtems_fs_init_helper =
>    /**
>     *  This is the primary Configuration Table for this application.
>     */
>-  rtems_configuration_table Configuration = {
>+  const rtems_configuration_table Configuration = {
>      CONFIGURE_EXECUTIVE_RAM_SIZE,             /* required RTEMS workspace */
>      CONFIGURE_STACK_SPACE_SIZE,               /* required stack space */
>      CONFIGURE_MAXIMUM_USER_EXTENSIONS,        /* maximum dynamic extensions */
>diff --git a/cpukit/sapi/include/rtems/config.h 
>b/cpukit/sapi/include/rtems/config.h
>index 55b7bda..ed869ec 100644
>--- a/cpukit/sapi/include/rtems/config.h
>+++ b/cpukit/sapi/include/rtems/config.h
>@@ -222,7 +222,7 @@ typedef struct {
>  /**
>   *   This is the configuration table generated by confdefs.h.
>   */
>-extern rtems_configuration_table  Configuration;
>+extern const rtems_configuration_table Configuration;
>
>  #if defined(RTEMS_MULTIPROCESSING)
>    /**
>
>My aim is to make it possible to call _Internal_error_Occurred() in every (!) 
>system state provided the read-only data is write protected.  Since the initial 
>extensions are part of the Configuration this change is the first step.  It is 
>also beneficial for targets with a small internal RAM.
>
>-- 
>Sebastian Huber, embedded brains GmbH
>
>Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
>Phone   : +49 89 18 90 80 79-6
>Fax     : +49 89 18 90 80 79-9
>E-Mail  : sebastian.huber at embedded-brains.de
>PGP     : Public key available on request.
>
>Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>
>_______________________________________________
>rtems-devel mailing list
>rtems-devel at rtems.org
>http://www.rtems.org/mailman/listinfo/rtems-devel




More information about the devel mailing list