[PATCH 0/4] libmm: support for memory management hardware
ralf.corsepius at rtems.org
Fri Oct 12 04:48:46 UTC 2012
On 10/11/2012 09:10 PM, Gedare Bloom wrote:
> This patch series adds support for handling memory management
> hardware such as MMUs/MPUs. This work is the result of 3 GSOC
> efforts with contributions from Aanjhan Ranganathan, Quanming Shi,
> and Hesham Al-Matary as student coders, and Thomas Doerfler,
> Peter Dufault, and Gedare Bloom as primary mentors. These specific
> patches are my (Gedare) revisions to the last pull request from
> Hesham's GSOC2012 project. My revisions were mainly stylistic.
To me, these patches need further work.
* Many types seem to be used incorrectly (e.g. uint32_t instead of size_t).
Symptom of this presumed incorrectnesses are the amount of casts being
used in address arithmetic. If the types were correct, most of the cast
should not be necessary.
* There are local extern vars to share vars between files.
As mentioned several times before, this means, these works do not
implement a proper API.
* The copyrights are questionable and possibly incorrect:
Most files state "Copyright OAR 1989-2012".
Have these files been derived from older files in RTEMS? If so, the
files they have been derived from should better be mentioned somewhere.
Are these files new? Then these files _are_ copyrighted "2012 only" by
their respective authors due to legal constraints.
* Formating issues, such as tabs in Makefile.ams, etc.
More information about the devel