[rtems-libbsd commit] freebsd-userspace/Makefile: Resolve conflict so ifconfig and netstat are both here

[Ralf Corsepius]

On 09/07/2012 08:15 PM, Joel Sherrill wrote:
> Module:    rtems-libbsd
> Branch:    master
> Commit:    e6fe77ef56f424b0cf72080fc37163be44f14ee8
> Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=e6fe77ef56f424b0cf72080fc37163be44f14ee8
>
> Author:    Joel Sherrill <joel.sherrill at oarcorp.com>
> Date:      Fri Sep  7 13:19:21 2012 -0500
>
> freebsd-userspace/Makefile: Resolve conflict so ifconfig and netstat are both here
>
> ---
>
>   freebsd-userspace/Makefile                        |   27 +++++++++++++++++++++
>   freebsd-userspace/lib/libc/include/libc_private.h |    4 +++
>   freebsd-userspace/rtems/include/namespace.h       |    2 +
>   testsuite/netshell01/Makefile                     |    2 +-
>   4 files changed, 34 insertions(+), 1 deletions(-)
>
> diff --git a/freebsd-userspace/Makefile b/freebsd-userspace/Makefile
> index 8e8adee..7472688 100644
> --- a/freebsd-userspace/Makefile
> +++ b/freebsd-userspace/Makefile
> @@ -7,6 +7,7 @@ include $(PROJECT_ROOT)/make/leaf.cfg
>   CFLAGS += -I include
>   CFLAGS += -I rtems/include
>   CFLAGS += -I lib/libc/include
> +CFLAGS += -I lib/netgraph
>   CFLAGS += -I sys
>   CFLAGS += -I local

This is the 3rd time, I am saying this:

-I<blank><dir> is non-portable.

RTFM gcc:



GCC(1)                                                           GNU 
                                                    GCC(1)

NAME
        gcc - GNU project C and C++ compiler

SYNOPSIS
        gcc [-c|-S|-E] [-std=standard]
            [-g] [-pg] [-Olevel]
            [-Wwarn...] [-pedantic]
            [-Idir...] [-Ldir...]
            [-Dmacro[=defn]...] [-Umacro]
            [-foption...] [-mmachine-option...]
            [-o outfile] [@file] infile...
...


Note: -Idir and -Ldir


You are relying on gcc being forgiving on -I<blank><dir> being a common 
user-mistake. If you'd be using other compilers, you'd notice there are 
compilers which are less forgiving.

Ralf