[PATCH] New fstest hitting rfs bitmaps - fsrfsbitmap01

Chris Johns chrisj at rtems.org
Thu Sep 27 01:55:26 UTC 2012

Krzysztof Mięsowicz wrote:
> I'm sending patch with new fstest. It seems to almost completely cover
> rfs_bitmap_* symbols. This test is extended version of
> rtems_rfs_bitmap_ut.c which was written by Chris Johns.

Looks fine. It is nice to see this code being tested and full coverage 
be achieved.

The only reason I placed the original test code in the RFS directory was 
to contain the test in the RFS source package. If the code was moved to 
another machine to allow support on other hosts, say via FUSE, the test 
could travel with it.

We should have only one copy of the test so if the test stays in the 
testsuite tree the other file should be removed. I do not mind this 
patch being applied with the other test being removed.

> Please, take a look at it and point any mistakes.
> Chris, please look at copyright note and see if it is good for you, if
> not - please suggest right version :)

It is fine. Normally you do not remove an existing copyright notice.


More information about the devel mailing list