[PATCH] Updated legacy code in ata & dec21140

Vipul Nayyar nayyar_vipul at yahoo.com
Thu Aug 1 15:41:50 UTC 2013


Thanks for pointing that out.

I added "#include <rtems/irq-extension.h>" in ata.c  so that the generic methods could work. Shouldn't including the extensions header solve the problem ?

I can add ifdefs in the libchip files, like it's already done in ata.c .  But for example in dec21140 & other files, when an interrupt is installed, do I need to use mthods like rtems_interrupt_catch() for simple vectored architectures ?

Vipul Nayyar 

 From: Joel Sherrill <joel.sherrill at oarcorp.com>
To: Sebastian Huber <sebastian.huber at embedded-brains.de> 
Cc: "rtems-devel at rtems.org" <rtems-devel at rtems.org> 
Sent: Thursday, 1 August 2013 8:34 PM
Subject: Re: [PATCH] Updated legacy code in ata & dec21140

On 8/1/2013 9:50 AM, Sebastian Huber wrote:
> Hello Vipul,
> the libchip stuff will be compiled for every BSP.  So I think this change will
> only work if every BSP provides the IRQ extensions API.
The libchip drivers should have an ifdef for simple vectored
to hide the PIC code.

Compiling it for say an m68k BSP should be a good double check.

FWIW the sparc BSPs are simple vectored but support this
API as well.

Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985

rtems-devel mailing list
rtems-devel at rtems.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130801/e4a1b755/attachment.html>

More information about the devel mailing list