[PATCH] bsp/lm4f120: new BSP to support TI LM4F120 XL LaunchPad board

[Eugeniy Meshcheryakov]

Hi,

I had not time yet to find out how to make this patch work with my
board, but there are some strange places in this patch.

20 серпня 2013 о 18:51 +0200 Karel Gardas написав(-ла):
> +  lm3s69xx_syscon_delay_3x_clocks(524288);
What is this large delay for? Where the number came from?

> +
> +  rcc = (rcc & ~(SYSCONRCC_XTAL_MSK))
> +      | SYSCONRCC_XTAL(LM3S69XX_XTAL_CONFIG);
> +  rcc2 = (rcc2 & ~(SYSCONRCC2_PWRDN2 | SYSCONRCC2_USERCC2 | SYSCONRCC2_OSCSRC2_MSK))
> +      | SYSCONRCC2_USERCC2 | SYSCONRCC2_OSCSRC2_MSK;
Why are you both resetting and later setting SYSCONRCC2_USERCC2 in this
expression? You do the same with SYSCONRCC2_OSCSRC2_MSK. Oring with
SYSCONRCC2_OSCSRC2_MSK cannot be possibly correct, you should use some
constant similar to SYSCONRCC_OSCSRC_IOSC. SYSCONRCC2_OSCSRC2_MSK = 7 in
this field corresponds to 32 kHz oscillator that I dont have available
on my board.

Regards,
Eugeniy Meshcheryakov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130825/77f60a25/attachment.bin>