[PATCH] Updated legacy code in ata & dec21140

[Joel Sherrill]

On 8/1/2013 11:30 AM, Vipul Nayyar wrote:
> Ok, I understand that including irq-extension.h in libchip drivers is 
> not required.
>
> So, you agree that using ifdefs is the way to go. I should use IRQ API 
> methods & rtems_interrupt_catch() for simple vectored architectures 
> like it's done in ata.c. Right ?
>
Without looking at the code, Yes. :)

Simple vectored architectures should use rtems_interrupt_catch().


> Regards
> Vipul Nayyar
>
>
> ------------------------------------------------------------------------
> *From:* Sebastian Huber <sebastian.huber at embedded-brains.de>
> *To:* Vipul Nayyar <nayyar_vipul at yahoo.com>
> *Cc:* Joel Sherrill <joel.sherrill at oarcorp.com>; 
> "rtems-devel at rtems.org" <rtems-devel at rtems.org>
> *Sent:* Thursday, 1 August 2013 9:24 PM
> *Subject:* Re: [PATCH] Updated legacy code in ata & dec21140
>
> On 2013-08-01 17:41, Vipul Nayyar wrote:
> >
> > I added "#include <rtems/irq-extension.h>" in ata.c  so that the generic
> > methods could work. Shouldn't including the extensions header solve 
> the problem ?
>
> The BSPs providing the IRQ extensions API include this file via 
> <bsp/irq.h>
> indirectly and they should define BSP_FEATURE_IRQ_EXTENSION in <bsp.h>.
>
> -- 
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone  : +49 89 189 47 41-16
> Fax    : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de 
> <mailto:sebastian.huber at embedded-brains.de>
> PGP    : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
>


-- 
Joel Sherrill, Ph.D.              Director of Research & Development
joel.sherrill at OARcorp.com         On-Line Applications Research
Ask me about RTEMS: a free RTOS   Huntsville AL 35805
Support Available                 (256) 722-9985

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130801/416c236e/attachment-0001.html>