[VirtLayer] Midterm patches and blog update

Gedare Bloom gedare at rtems.org
Wed Aug 14 18:00:19 UTC 2013


I'm not sure where you started with this BSP, but the best example of
how to do a BSP is probably the arm/pbxa9.

Notes:
* Get rid of $Id$ anywhere
* Address any TODOs
* Replace the copyright with your own in console/console.c
* Prefer to use doxygen comments to document functions when needed at
their declarations i.e. in header files. Do not need to redocument at
their definition in c files.
* Is __attribute__((fastcall)) needed for some reasons? Is it C99 or a
GCC'ism? Prefer to avoid GCC'isms.
* replace  "XXX : put yours in here" with your copyright
* Rename all virt_xxxYyy() with _CPU_Virtual_Xxx_yyy() or something
appropriate to RTEMS naming conventions.
* Rename virtPok to be virtpok, or better yet virtualpok, or maybe just pok.
* Add copyright and remove date. You can choose to leave
author/contact if you want, but put them together e.g. Phillip Eppelt
<phillip.eppelet at ...>
* Make every continuation line in a C-style comment start with a
space+asterisk, e.g. /* ....\n *....\n */
* Why are you checking for CPU_STACK_ALIGNMENT in start.S?
* Eliminate commented-out code from bspgetworkarea.c and state why you
need to use a custom rather than shared version.
* Replace any tabs in C code with 2 space characters, for example in
virtPok/start/start.c
* Are start.c and start.S both defining start symbols, and is only one
of them used? Eliminate dead code.
* Get rid of the custom bspstart.c if all it does is some
generic/useless print statements. Does the testsuites/samples/hello.c
work?
* the linkcmds is a link to linkcmds_old. I would prefer the linkcmds
file directly. If it is a straight copy of the i386 linkcmds you could
make the i386/startup/linkcmds go into
i386/shared/startup/linkcmds.base, and then just include it from pc386
and virtPok.
* If linkcmds_pok is unused, do not include it.

-Gedare

On Wed, Jul 31, 2013 at 4:18 PM, Philipp Eppelt
<philipp.eppelt at mailbox.tu-dresden.de> wrote:
> Patch introducing libbsp/i386/virtPok BSP.
>
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel
>



More information about the devel mailing list