[PATCH 1/1] i386 libcpu-score changes

Philipp Eppelt philipp.eppelt at mailbox.tu-dresden.de
Tue Aug 20 09:20:50 UTC 2013


On 08/20/2013 11:09 AM, Sebastian Huber wrote:
> On 2013-08-20 10:55, philipp.eppelt at mailbox.tu-dresden.de wrote:
>> diff --git a/cpukit/score/cpu/i386/rtems/score/cpu.h
>> b/cpukit/score/cpu/i386/rtems/score/cpu.h
>> index 43422ed..68b0e53 100644
>> --- a/cpukit/score/cpu/i386/rtems/score/cpu.h
>> +++ b/cpukit/score/cpu/i386/rtems/score/cpu.h
>> @@ -29,9 +29,9 @@ extern "C" {
>>
>>   #include <rtems/score/types.h>
>>   #include <rtems/score/i386.h>
>> -
>> +#include <libcpu/cpu-score-split.h>
>>   #ifndef ASM
>> -#include <rtems/score/interrupts.h>    /* formerly in libcpu/cpu.h> */
>> +#include <libcpu/interrupts.h>    /* formerly in libcpu/cpu.h> */
> 
> The header files in cpukit must not use RTEMS header files outside the
> cpukit directory.
> 
> You must place the declarations in <rtems/score/cpu.h>.  You can move
> the implementation to libcpu.
> 

interrupts.h and cpu-score-split.h mainly consists of #defines that are
virtualization sensitive.
How can I declare defines in cpu.h and implement them in libcpu?

Shall I just redefine them in libcpu? Wouldn't that be confusing?



More information about the devel mailing list