[Patch] Removing legacy method from arm csb337

[Sebastian Huber]

On 07/02/2013 08:52 AM, Vipul Nayyar wrote:
>       /* install the interrupt handler */
> -    BSP_install_rtems_irq_handler(&at91rm9200_emac_isr_data);
> +    stc = rtems_interrupt_handler_install(
> +      at91rm9200_emac_isr_data.name,
> +      "Network",
> +      RTEMS_INTERRUPT_UNIQUE,
> +      at91rm9200_emac_isr_data.hdl,
> +      at91rm9200_emac_isr_data.handle
> +    );
> +    if (stc != RTEMS_SUCCESSFUL) {
> +    printk("RTEMS Interrupt handler not installed");
> +    }

Don't use printk() for error notification.  In case the driver framework has 
the ability to return an error status code, then use this.  Unfortunately the 
driver frameworks in RTEMS are quite sloppy with this, so I don't know one 
which uses this error strategy.  This gives you two options

1. assert()

2. rtems_fatal()

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.