[Patch] Removing legacy method from arm csb337

[Sebastian Huber]

Hello,

please don't include patches in the email body.  Please make sure that 
you don't introduce trailing white space.  If I apply your patch, then I 
get the following compiler warnings:

gmake[6]: Entering directory 
`/home/sh/git-build/b-csb337/arm-rtems4.11/c/csb337/lib/libbsp/arm/csb337'
arm-rtems4.11-gcc --pipe -B../../../../../.././lib/ 
-B../../../../../.././csb337/lib/ -specs bsp_specs -qrtems 
-DHAVE_CONFIG_H   -isystem ../../../../../.././csb337/lib/include 
-D__INSIDE_RTEMS_BSD_TCPIP_STACK__   -mstructure-size-boundary=8 
-mcpu=arm920 -mfpu=vfp -mfloat-abi=soft -O2 -g  -Wall 
-Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes 
-Wnested-externs -MT network_rel-network.o -MD -MP -MF 
.deps/network_rel-network.Tpo -c -o network_rel-network.o `test -f 
'network/network.c' || echo 
'/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/'`network/network.c
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:87:1: 
warning: function declaration isn't a prototype [-Wstrict-prototypes]
  static void at91rm9200_emac_isr_on();
  ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:88:1: 
warning: function declaration isn't a prototype [-Wstrict-prototypes]
  static void at91rm9200_emac_isr_off();
  ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:89:1: 
warning: function declaration isn't a prototype [-Wstrict-prototypes]
  static int at91rm9200_emac_isr_is_on();
  ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:207:10: warning: 
no previous prototype for 'phyread' [-Wmissing-prototypes]
  uint32_t phyread(uint8_t reg)
           ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:232:6: 
warning: no previous prototype for 'phywrite' [-Wmissing-prototypes]
  void phywrite(uint8_t reg, uint16_t data)
       ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:771:13: warning: 
function declaration isn't a prototype [-Wstrict-prototypes]
  static void at91rm9200_emac_isr_on()
              ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:784:13: warning: 
function declaration isn't a prototype [-Wstrict-prototypes]
  static void at91rm9200_emac_isr_off()
              ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:795:12: warning: 
function declaration isn't a prototype [-Wstrict-prototypes]
  static int at91rm9200_emac_isr_is_on()
             ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:784:13: warning: 
'at91rm9200_emac_isr_off' defined but not used [-Wunused-function]
  static void at91rm9200_emac_isr_off()
              ^
/home/sh/rtems-4.11/c/src/lib/libbsp/arm/csb337/network/network.c:795:12: warning: 
'at91rm9200_emac_isr_is_on' defined but not used [-Wunused-function]
  static int at91rm9200_emac_isr_is_on()
             ^

No all are your fault, but some are.

On 05/07/13 17:32, Vipul Nayyar wrote:
> Hello,
>
> Submitting the patch again. Hope I've made all the corrections that I mentioned in my previous email. The network.c file in arm csb337 currently uses 4 space indent in many functions. For the current function at91rm9200_emac_init() , I've made all the statements use 2 space indents. If the main changes in the following patch regarding the generic framework are correct, I'll update the whole file to use 2 space indent later.

Please don't format the code and do functional changes.  If the code 
uses two spaces for indentation, then use also two spaces.   If the code 
uses four spaces for indentation, then use also four spaces. If the code 
uses tabs for indentation, then use also tabs.

[...]

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.