[PATCH] Updated Legacy code in i386 pc386

[Vipul Nayyar]

Hello,

I put (rtems_interrupt_handler) casts because I was getting warnings. After I removed them now, I think it's working fine. Don't know how.

The indentation around line 684 in 3c509.c is surely correct. It's following the same indentation as above line 'resend = 0;' Have a look.

I removed the Clock_driver_support_at_tick_empty function because it was empty. So I think my current edit should suffice . Right ?

Passed sc directly to interrupt handler.

Regards
Vipul Nayyar 



________________________________
 From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: rtems-devel at rtems.org 
Sent: Wednesday, 24 July 2013 1:06 PM
Subject: Re: [PATCH] Updated Legacy code in i386 pc386
 

Hello Vipul,

can you please remove all the (rtems_interrupt_handler) casts.

On 2013-07-23 17:03, Vipul Nayyar wrote:
[...]
> @@ -746,8 +681,8 @@ int rtems_3c509_driver_attach (struct rtems_bsdnet_ifconfig *config )
>        */
>       overrun = 0;
>       resend = 0;
> -    ep_unit = 0;
> -    ep_boards = 0;
> +  ep_unit = 0;
> +  ep_boards = 0;

Here the indentation is wrong, please check other parts of the patch as well.

[...]
> @@ -326,7 +309,7 @@ void Clock_driver_support_initialize_hardware(void)
>
>     if ( use_8254 ) {
>       /* printk( "Use 8254\n" ); */
> -    Clock_driver_support_at_tick = Clock_driver_support_at_tick_empty;
> +    Clock_driver_support_at_tick = NULL;

What is the reason for this change?

[...]
> @@ -381,7 +381,7 @@ ne_check_status (struct ne_softc *sc, int from_irq_handler)
>   /* Handle an NE2000 interrupt.  */
>
>   static void
> -ne_interrupt_handler (rtems_irq_hdl_param cdata)
> +ne_interrupt_handler (void * cdata)
>   {
>     rtems_vector_number v = (rtems_vector_number) cdata;
>     struct ne_softc *sc;

I think you can get rid of ne_device_for_irno if you use the right cdata value 
(e.g. pass directly sc).

[...]

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
rtems-devel at rtems.org
http://www.rtems.org/mailman/listinfo/rtems-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130724/6c032af2/attachment-0001.html>