[PATCH] Updated Legacy code in i386 pc386
Vipul Nayyar
nayyar_vipul at yahoo.com
Thu Jul 25 13:56:13 UTC 2013
That means reverting that part should complete this patch. Right ?
Regards
Vipul Nayyar
________________________________
From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: rtems-devel at rtems.org
Sent: Thursday, 25 July 2013 7:01 PM
Subject: Re: [PATCH] Updated Legacy code in i386 pc386
Hello Vipul,
your patch llooks now very good. There is only one last issue left.
On 2013-07-24 15:51, Vipul Nayyar wrote:
> @@ -326,7 +309,7 @@ void Clock_driver_support_initialize_hardware(void)
>
> if ( use_8254 ) {
> /* printk( "Use 8254\n" ); */
> - Clock_driver_support_at_tick = Clock_driver_support_at_tick_empty;
> + Clock_driver_support_at_tick = NULL;
If you look in clockdrv_shell.h, then you see how this
Clock_driver_support_at_tick is used. I think we have now a potential NULL
pointer access (instead of a call to an empty function).
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
rtems-devel at rtems.org
http://www.rtems.org/mailman/listinfo/rtems-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130725/6e1889e9/attachment-0001.html>
More information about the devel
mailing list