[Patch] Removing legacy method from arm csb336

Joel Sherrill Joel.Sherrill at OARcorp.com
Thu Jun 27 11:06:19 UTC 2013

I think so. One BSP per patch. You may want to send in one BSP for review first. Then if you are moving quickly, send a batch of patches for an entire architecture. But one per BSP.

Uses outside the BSP can be similarly packaged.

Vipul Nayyar <nayyar_vipul at yahoo.com> wrote:

Just checking, that the right way to move forward for me would be identifying legacy code and submitting patches ?? like I did with removing the use of BSP_install_rtems_irq_handler from arm csb336.

Vipul Nayyar

From: Joel Sherrill <Joel.Sherrill at OARcorp.com>
To: Vipul Nayyar <nayyar_vipul at yahoo.com>
Cc: Sebastian Huber <sebastian.huber at embedded-brains.de>; "rtems-devel at rtems.org" <rtems-devel at rtems.org>
Sent: Thursday, 27 June 2013 2:16 PM
Subject: Re: [Patch] Removing legacy method from arm csb336

The goal of this is to kill bad examples. It is legacy and we don't want people to use it anymore. These should be mechanical changes. Vipul should be able to provide instructions for users with external drivers to make the changes.

Fixing these could break here or there but if we don't remove uses of deprecated methods then users will use them in new BSPs and that is unacceptable.

Vipul Nayyar <nayyar_vipul at yahoo.com> wrote:


According to the discussions with my mentor Joel Sherill, I was suggested to kill all legacy/deprecated API uses in the tree which are defined in irq-legacy.c as part of my project. I guess Dr Joel can guide us better whether all of the deprecated methods need to be removed or only some of them. cc'ing Dr Joel for guidance on this.

Vipul Nayyar

From: Sebastian Huber <sebastian.huber at embedded-brains.de>
To: rtems-devel at rtems.org
Sent: Thursday, 27 June 2013 1:48 PM
Subject: Re: [Patch] Removing legacy method from arm csb336

On 06/26/2013 05:28 PM, Vipul Nayyar wrote:
> For my GSOC Project Unified APIs,  a public google doc has been setup (
> https://docs.google.com/document/d/1W9DMnpocXUKXiQMxHbbp0aG-ecuh94P-3N7hxEJmcgs/edit?usp=sharing)
> for community viewing. In order to establish this unified pattern across all
> BSPs, I felt that deprecated methods stored in irq-legacy.c should be dealt
> with first. So, I'm attaching a very basic patch which removes the deprecated
> method BSP_install_rtems_irq_handler from arm csb336 and instead makes use
> of rtems_interrupt_handler_install, as suggested in irq-legacy.c. Please do
> give suggestions if I'm heading the right way, and any modifications that this
> patch may require.

I would not touch the existing code that uses these legacy functions.  The irq-legacy.c is provided to keep existing code as is.

-- Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone  : +49 89 189 47 41-16
Fax    : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de<mailto:sebastian.huber at embedded-brains.de>
PGP    : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
rtems-devel mailing list
rtems-devel at rtems.org<mailto:rtems-devel at rtems.org>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20130627/a123cfc0/attachment.html>

More information about the devel mailing list