[PATCH 8/9] fsdsosfsname01: Ensure endian correctness

[Rempel, Cynthia]

>
>> On 05/31/2013 03:42 PM, Ralf Kirchner wrote:
>>> diff --git a/testsuites/fstests/fsdosfsname01/image_bin_le_multibyte.h
>>> b/testsuites/fstests/fsdosfsname01/image_bin_le_multibyte.h
>>> +/*
>>> + *  Declarations for C structure representing a disk image
>>> + *
>>> + *  WARNING: Automatically generated -- do not edit!
>>> + */
>>> +#ifndef IMAGE_BIN_LE_MULTIBYTE_H_
>>> +#define IMAGE_BIN_LE_MULTIBYTE_H_
>>> +
>>
>> AFAIU, this code qualifies is a hex dump of some binary, seemingly having been
>> generated by some seemingly unfree tool.
>It is generated from init.c if PRINT_DISK_IMAGE != 0.

Thanks Sebastian for the clarification :)

Could a rule in the Makefile.am be added to generate testsuites/fstests/fsdosfsname01/image_bin_le_multibyte.h and then not include the file in the repo?
If the file is needed for comparing a new build vs. the working build (for testing purposed), then it makes sense to keep image_bin_le_multibyte.h...

Could the line 
+ *  WARNING: Automatically generated -- do not edit!

be changed to
+ *  WARNING: Automatically generated by init.c if PRINT_DISK_IMAGE != 0 -- do not edit!

>>
>> => In this shape this code violates the RTEMS license and may not be applied to
>> RTEMS.
>>
>>
>> Please reimplement this by using free tools.
>So if I use notepad.exe on Windows to write RTEMS source code I violate the
>RTEMS license?
I suspect there was a little confusion on how the file was generated, but it appears Sebastian cleared that up quite well.
Cindy
--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
_______________________________________________
rtems-devel mailing list
rtems-devel at rtems.org
http://www.rtems.org/mailman/listinfo/rtems-devel