[Patch] Removing legacy method from arm csb336

[Sebastian Huber]

On 06/26/2013 05:28 PM, Vipul Nayyar wrote:
> diff --git a/c/src/lib/libbsp/arm/csb336/console/uart.c
> b/c/src/lib/libbsp/arm/csb336/console/uart.c
> index 4dc409b..0c4ab39 100644
> --- a/c/src/lib/libbsp/arm/csb336/console/uart.c
> +++ b/c/src/lib/libbsp/arm/csb336/console/uart.c
> @@ -246,9 +246,13 @@ static int imx_uart_first_open(int major, int minor, void
> *arg)
>       imx_uart_data[minor].tty   = args->iop->data1;
> +    const rtems_irq_connect_data *uart_tx = &imx_uart_tx_isr_data[minor];
> +    const rtems_irq_connect_data *uart_rx = &imx_uart_rx_isr_data[minor];

Please remove the rtems_irq_connect_data items.  Make sure that the on/off 
helper side effects are preserved as part of the install/remove operation.

> +
> +
>   #if defined(USE_INTERRUPTS)
> -    BSP_install_rtems_irq_handler(&imx_uart_tx_isr_data[minor]);
> -    BSP_install_rtems_irq_handler(&imx_uart_rx_isr_data[minor]);
> +    rtems_interrupt_handler_install(uart_tx->name,"LEGACY
> REMOVED",RTEMS_INTERRUPT_UNIQUE,uart_tx->hdl,uart_tx->handle);
> +    rtems_interrupt_handler_install(uart_rx->name,"LEGACY
> REMOVED",RTEMS_INTERRUPT_UNIQUE,uart_rx->hdl,uart_rx->handle);

Please replace "LEGACY REMOVED" with something useful.  Adhere the 80 
characters line limit, e.g. write

rtems_interrupt_handler_install(
   uart_rx->name,
   "LEGACY REMOVED",
   RTEMS_INTERRUPT_UNIQUE,
   uart_rx->hdl,
   uart_rx->handle
);

Check the return value of this function at least with an assert().

>       imx_uart_data[minor].regs->cr1 |= MC9328MXL_UART_CR1_RRDYEN;
>   #endif
> diff --git a/c/src/lib/libbsp/arm/csb336/network/network.c
> b/c/src/lib/libbsp/arm/csb336/network/network.c
> index e513595..7f54230 100644
> --- a/c/src/lib/libbsp/arm/csb336/network/network.c
> +++ b/c/src/lib/libbsp/arm/csb336/network/network.c
> @@ -334,7 +334,7 @@ void  mc9328mxl_enet_init_hw(mc9328mxl_enet_softc_t *sc)
>   MC9328MXL_GPIOA_IMR |= bit(3);
>       /* Install the interrupt handler */
> -    BSP_install_rtems_irq_handler(&mc9328mxl_enet_isr_data);
> +    rtems_interrupt_handler_install(mc9328mxl_enet_isr_data.name,"LEGACY
> REMOVED",RTEMS_INTERRUPT_UNIQUE,mc9328mxl_enet_isr_data.hdl,mc9328mxl_enet_isr_data.handle);
>   } /* mc9328mxl_enet_init_hw() */


-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.