[PATCH] [libbsp/shared] Fixed compiler warning - no previous prototype for 'bsp_fatal_extension'

[Sebastian Huber]

On 03/19/2013 01:17 PM, Andreas Heinig wrote:
> I see this warning for my own BSP's.

In this case your BSPs should include <bsp/default-initial-extension.h> in 
<bsp.h>.  This <bsp/default-initial-extension.h> defines also 
BSP_INITIAL_EXTENSION which is used by <rtems/confdefs.h>

>
> Is it really intended that every BSP defines the prototype of the function on
> its own?

No, it is intended that <bsp.h> includes <bsp/default-initial-extension.h> if 
this BSP uses the shared bspclean.c.

> Btw.: This is also the case for the function: rtems_exception_init_mngt().

Yes, this stuff is improvable.

>
> In my opinion, it is much better to have a system-wide deceleration of common
> interface functions. This would be extremely helpful, especially if somebody
> wants to change an interface. In that case, the compiler can easily detect code
> which was not ported.

Yes, global functions without exactly one declaration in a header file per 
architecture are broken.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.