[PATCH 2/4] score: Remove idle field of Per_CPU_Control

Sebastian Huber sebastian.huber at embedded-brains.de
Wed May 29 20:08:58 UTC 2013


On 29/05/13 21:56, Joel Sherrill wrote:
> On 5/29/2013 2:35 PM, Sebastian Huber wrote:
>> On 29/05/13 21:14, Joel Sherrill wrote:
>>> I think the use of _Objects_Name_to_id_u32 should be
>>> calling rtems_task_ident.
>> The problem is that the idle threads are not RTEMS tasks.  You cannot
>> find them with rtems_task_ident().
>>
> That's right. :(
>
> It is still a violation of the layering. I wonder if we need a helper.

Using _Thread_Idle was also a violation, so nothing changes in this respect.

>
> And the fast idle trick is also violating the layering. Grrr...
>
>
> Also in a multi-core system, all the IDLE threads have the same name.
> So you don't know which one you are getting. Is this OK based on
> your test change?

This is a single processor test.  On SMP this test is invalid.

>
> FWIW it is not ok to have no tasks in the ready set.
>

Yes, the cardinality of the ready set must be greater than or equal to 
the processor count.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list