[rtems commit] Shared MMU initialization for ARM BSPs and RaspberryPi MMU support
gedare at rtems.org
Fri Oct 4 12:57:44 UTC 2013
On Fri, Oct 4, 2013 at 5:58 AM, Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
> On 2013-10-04 11:07, Hesham Moustafa wrote:
>> On Fri, Oct 4, 2013 at 9:50 AM, Sebastian Huber
>> <sebastian.huber at embedded-brains.de
>> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>> On 2013-10-03 14:49, Gedare Bloom wrote:
>> @@ -87,9 +90,9 @@
>> - /* Initialize translation table with invalid entries */
>> + /* Initialize translation table with fixed-map read-write
>> entries */
>> for (i = 0; i < ARM_MMU_TRANSLATION_TABLE___ENTRY_COUNT; ++i)
>> - ttb [i] = 0;
>> + ttb [i] = (i << ARM_MMU_SECT_BASE_SHIFT) |
>> What is the reason for this change? I don't think that unconditional
>> read-write access is a good idea.
>> I made this change when I was trying to get RaspberryPi MMU initialization
> Then it is probably better to fix the memory map description of this
> particular BSP.
>> Also I thought
>> the default behavior for RTEMS is the unprotected mode, and the new
>> (limitation) attributes
>> are new and should be applied when needed (by configuration table at
>> startup or
> Allow everything with explicit deny is very bad design. It should be always
> deny everything with explicit allow.
Thanks Sebastian, I agree with everything you say here Hesham, please
revert this to initializing to 0 attributes and fix the raspberrypi
> Sebastian Huber, embedded brains GmbH
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone : +49 89 189 47 41-16
> Fax : +49 89 189 47 41-09
> E-Mail : sebastian.huber at embedded-brains.de
> PGP : Public key available on request.
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> rtems-devel mailing list
> rtems-devel at rtems.org
More information about the devel