Original cpuset.h for review

Thomas Doerfler Thomas.Doerfler at embedded-brains.de
Tue Oct 15 06:00:36 UTC 2013

Hi Joel,

just some comments from me:

1.) In the typedef for cpu_set_t, it might be better to use the 
_NCPUWORDS macro instead of duplicating its expansion

2.) In the operations _OR, _AND etc, you used "(_set)" instead of 
"(_src2)" for the second operand

3.) The term "(_cpu)/_NCPUBITS" is duplicated to get the index into the 
cpuset table. This might be done through a macro (__cpu_set_idx ?) aswell.



Am 14.10.2013 20:47, schrieb Joel Sherrill:
> Hi
> This has had limited review but should close if you ignore
> that I need to add some comments.
> This will go into the RTEMS specific subdirectory of
> newlib and be accompanied by prototypes of various
> pthread methods that use this. This is just the
> first step.
> Comments.
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel

embedded brains GmbH
Thomas Doerfler
Dornierstr. 4
D-82178 Puchheim
email: Thomas.Doerfler at embedded-brains.de
Phone: +49-89-18 94 741-12
Fax:   +49-89-18 94 741-09
PGP: Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

More information about the devel mailing list