[PATCH] nvdisk: swap arguments to checksum helper

Joel Sherrill joel.sherrill at OARcorp.com
Thu Sep 5 18:44:04 UTC 2013


How did this ever work?

On 9/5/2013 1:29 PM, Gedare Bloom wrote:
> The arguments to rtems_nvdisk_calc_crc16() are reversed when called from
> rtems_nvdisk_page_checksum().
>
> 26053 Operands don't affect result
> ---
>   cpukit/libblock/src/nvdisk.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpukit/libblock/src/nvdisk.c b/cpukit/libblock/src/nvdisk.c
> index db97179..32a56b3 100644
> --- a/cpukit/libblock/src/nvdisk.c
> +++ b/cpukit/libblock/src/nvdisk.c
> @@ -422,7 +422,7 @@ rtems_nvdisk_page_checksum (const uint8_t* buffer, uint32_t page_size)
>     uint32_t i;
>   
>     for (i = 0; i < page_size; i++, buffer++)
> -    cs = rtems_nvdisk_calc_crc16 (cs, *buffer);
> +    cs = rtems_nvdisk_calc_crc16 (*buffer, cs);
>   
>     return cs;
>   }


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985




More information about the devel mailing list