[PATCH] dosfs: Unsigned compared against 0

Joel Sherrill joel.sherrill at OARcorp.com
Thu Sep 5 17:31:50 UTC 2013


Gedare.. are these from Coverity Scan? They seem
remarkably picky otherwise. :)

If they are, ask when you want another run submitted.

--joel

On 9/5/2013 12:10 PM, Gedare Bloom wrote:
> Fix the type of "cmpltd" to be ssize_t so that assigning it to -1
> will terminate processing as intended.
> ---
>   cpukit/libfs/src/dosfs/msdos_dir.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cpukit/libfs/src/dosfs/msdos_dir.c b/cpukit/libfs/src/dosfs/msdos_dir.c
> index 253203c..d7f6823 100644
> --- a/cpukit/libfs/src/dosfs/msdos_dir.c
> +++ b/cpukit/libfs/src/dosfs/msdos_dir.c
> @@ -78,7 +78,7 @@ msdos_dir_read(rtems_libio_t *iop, void *buffer, size_t count)
>       const size_t       buf_size = converter->buffer.size;
>       uint32_t           start = 0;
>       ssize_t            ret = 0;
> -    uint32_t           cmpltd = 0;
> +    ssize_t            cmpltd = 0;
>       uint32_t           j = 0, i = 0;
>       uint32_t           bts2rd = 0;
>       uint32_t           cur_cln = 0;


-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985




More information about the devel mailing list