[PATCH 2/5] JFFS2: Import from eCos

[Chris Johns]

Where is the device support ?

Sebastian Huber wrote:
> diff --git a/cpukit/libfs/src/jffs2/src/compat-rbtree.c b/cpukit/libfs/src/jffs2/src/compat-rbtree.c
> new file mode 100644
> index 0000000..5bc1cc5
> --- /dev/null
> +++ b/cpukit/libfs/src/jffs2/src/compat-rbtree.c
> @@ -0,0 +1,408 @@
> +/*========================================================================
> +//
> +//      rbtree.c
> +//
> +//      Red Black tree implementation
> +//
> +//========================================================================
> +// ####ECOSGPLCOPYRIGHTBEGIN####
> +// -------------------------------------------
> +// This file is part of eCos, the Embedded Configurable Operating System.
> +// Copyright (C) 1998, 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
> +//
> +// eCos is free software; you can redistribute it and/or modify it under
> +// the terms of the GNU General Public License as published by the Free
> +// Software Foundation; either version 2 or (at your option) any later
> +// version.
> +//
> +// eCos is distributed in the hope that it will be useful, but WITHOUT
> +// ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> +// FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License
> +// for more details.
> +//
> +// You should have received a copy of the GNU General Public License
> +// along with eCos; if not, write to the Free Software Foundation, Inc.,
> +// 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
> +//
> +// As a special exception, if other files instantiate templates or use
> +// macros or inline functions from this file, or you compile this file
> +// and link it with other works to produce a work based on this file,
> +// this file does not by itself cause the resulting work to be covered by
> +// the GNU General Public License. However the source code for this file
> +// must still be made available in accordance with section (3) of the GNU
> +// General Public License v2.
> +//
> +// This exception does not invalidate any other reasons why a work based
> +// on this file might be covered by the GNU General Public License.
> +// -------------------------------------------
> +// ####ECOSGPLCOPYRIGHTEND####
> +//========================================================================
> +//#####DESCRIPTIONBEGIN####
> +//
> +// Author(s):     Niels Provos/OpenBSD
> +// Contributors:  dwmw2
> +// Date:          2003-01-21
> +// Purpose:       This file provides an implementation of red-black trees.
> +// Description:   Derived from OpenBSD src/sys/sys/tree.h
> +// Usage:
> +//
> +//####DESCRIPTIONEND####
> +//
> +//======================================================================
> +*/
> +
> +/*	$OpenBSD: tree.h,v 1.7 2002/10/17 21:51:54 art Exp $	*/
> +/*
> + * Copyright 2002 Niels Provos<provos at citi.umich.edu>
> + * All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + * 1. Redistributions of source code must retain the above copyright
> + *    notice, this list of conditions and the following disclaimer.
> + * 2. Redistributions in binary form must reproduce the above copyright
> + *    notice, this list of conditions and the following disclaimer in the
> + *    documentation and/or other materials provided with the distribution.
> + *
> + * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> + * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
> + * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
> + * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
> + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
> + * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
> + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
> + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
> + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
> + * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> + */
> +

Clause 2 concerns me.

Is mixing GPLv2+exception and a BSD type license like this ok ?

> diff --git a/cpukit/libfs/src/jffs2/src/dir-rtems.c b/cpukit/libfs/src/jffs2/src/dir-rtems.c
> new file mode 100644
> index 0000000..16b62cc
> --- /dev/null
> +++ b/cpukit/libfs/src/jffs2/src/dir-rtems.c
> @@ -0,0 +1,371 @@
> +/*
> + * JFFS2 -- Journalling Flash File System, Version 2.
> + *
> + * Copyright (C) 2001-2003 Free Software Foundation, Inc.
> + *
> + * Created by David Woodhouse<dwmw2 at cambridge.redhat.com>
> + *
> + * For licensing information, see the file 'LICENCE' in this directory.
> + *
> + * $Id: dir-ecos.c,v 1.11 2005/02/08 19:36:27 lunn Exp $
> + *
> + */

I cannot find a file called 'LICENCE' in any of the patches ?

Adding code to RTEMS that is copyright FSF is something we need to 
consider carefully. I do not think this has happened before.

Chris