[PATCH 1/2] arm: Add support for FPv4-SP floating point unit

[Sebastian Huber]

On 08/12/2014 04:08 PM, Gedare Bloom wrote:
> On Tue, Aug 12, 2014 at 7:32 AM, Peter Dufault<dufault at hda.com>  wrote:
>> >
>> >On Aug 11, 2014, at 17:02 , Gedare Bloom<gedare at rtems.org>  wrote:
>> >
>>>> >>>+#ifdef ARM_MULTILIB_VFP
>>>> >>>+       /* CPACR is located at address 0xe000ed88 */
>>>> >>>+       ldr.w   r0, =0xe000ed88
>>> >>Maybe the constant should be provided by a header file? The comments
>>> >>are nice though. And I didn't see anything else in the rest, although
>>> >>my arm asm is rusty.
>>> >>
>>> >>
>> >
>> >When used in a single place in a hardware specific C file I prefer a constant.  When I'm suspicious I'm comparing definitions against the reference manuals looking for transcription errors and I'd rather avoid the indirection.  Obviously it needs an appropriate constant (which Sebastian provides).
>> >
> True, and the comment is pretty clear. So, either way. I guess I am
> surprised the constant is only used in this one place.

If there is only one place, then there is no real need for a define.  I 
added improved exception support, so now we have two places and a define.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.