feedback on Re: [PATCH v3] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

[Sebastian Huber]

On 21/08/14 11:21, Pavel Pisa wrote:
> Hello Sebastian,
>
> On Thursday 21 of August 2014 08:59:15 Sebastian Huber wrote:
>> On 20/08/14 20:17, Joel Sherrill wrote:
>>> Hi
>>>
>>> Initial quick feedback.  I build normally with --enable-rtems-debug
>>> and the tms570ls3137_hdk variant failed to build with this
>>> failure:
>>>
>>> arm-rtems4.11-gcc --pipe -DHAVE_CONFIG_H   -I../../..
>>> -I../../../../cpukit/../../../tms570ls3137_hdk/lib/include  -DASM
>>> -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG -Wall
>>> -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes
>>> -Wnested-externs -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG
>>
>> Why do we have this -ggdb3 -NDEBUG set?
>
> May be, we have not understood right flags intended use.
> I my understanding is, that CFLAGS_OPTIMIZE_V are used for
> build without "--enable-rtems-debug" and flags "CFLAGS_DEBUG_V"
> when "--enable-rtems-debug" is present.
>
> Then BSP defines in preferred way. We have build with default
> options (without internal debug). This means that RTEMS
> binary should be optimized and without internal self debug
> code (NDEBUG). But want to have as much debug information
> for external debugger as possible. This is -ggdb/-ggdb3.

Such options should be set in a BSP independent way.  This NDEBUG is currently 
not controlled by configure options.

>
> In the fact the settings has been taken from other boards.
> Actually from
>    arm/lpc176x/make/custom/lpc1768_mbed.cfg
> but rtl22xx.cfg is the same and -g is in almost every other ARM *.cfg.

Looks like we have to clean this up.

[...]


-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.