feedback on Re: [PATCH v3] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

[Pavel Pisa]

On Wednesday 20 of August 2014 20:17:47 Joel Sherrill wrote:
> Hi
>
> Initial quick feedback.  I build normally with --enable-rtems-debug
> and the tms570ls3137_hdk variant failed to build with this
> failure:
>
> arm-rtems4.11-gcc --pipe -DHAVE_CONFIG_H   -I../../..
> -I../../../../cpukit/../../../tms570ls3137_hdk/lib/include  -DASM
> -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG -Wall
> -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes
> -Wnested-externs -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG
> -Wall -Wmissing-prototypes -Wimplicit-function-declaration
> -Wstrict-prototypes -Wnested-externs -MT
> libscorecpu_a-arm-context-volatile-clobber.o -MD -MP -MF
> .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo -c -o
> libscorecpu_a-arm-context-volatile-clobber.o `test -f
> 'arm-context-volatile-clobber.S' || echo
> '../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/'`arm-conte
>xt-volatile-clobber.S mv -f
> .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo
> .deps/libscorecpu_a-arm-context-volatile-clobber.Po
> In file included from
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/percpu
>.h:25:0, from
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/system.h:23,
>                  from
> ../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/cpu.c:29:
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/isrloc
>k.h: In function '_ISR_lock_ISR_disable_and_acquire':
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/assert
>.h:38:46: error: '__ASSERT_FUNC' undeclared (first use in this function)
>            __assert_func( __FILE__, __LINE__, __ASSERT_FUNC, #_e ) )
>                                               ^
>
> Since there was some work to add a new ARM variant, I am suspicious that
> a .h file is missing when this is compiled for Rx ARM variants.
>
> I didn't build other variants and am trying again with debug disabled.

Hello Joel,

we need to recheck that.

We have been using optimized build and our target is build for SDRAM.
We tested internal RAM as well. The flashing to start RTEMS image
from address 0 has not been checked yet and cannot work with additional
initial code implementation.

There would be problem to build some larger test for internal
RAM variant because they overflow.

I have run ticker test on the board compiled from actual RTEMS mainline
with next configuration options and everything seems OK for this setup
on real HW

../../../git/rtems/configure --target=arm-rtems4.11 --prefix=/opt/rtems4.11 \
  --enable-rtems-inlines --disable-multiprocessing --enable-cxx \
  --enable-rdbg --enable-maintainer-mode --enable-tests=samples \
  --enable-networking --enable-posix --enable-itron --disable-ada \
  --disable-expada --disable-multilib --disable-docs \
  --enable-rtemsbsp="tms570ls3137_hdk_sdram"

I expect that inclusion of of assert.h or something similar world help
to debug case. I look at it now or tomorrow.

As for regular RTEMS build it would worth to limit it/enable only
tms570ls3137_hdk_sdram, other variants are more or less
waste of compilation time for now. On the other hand,
tms570ls3137_hdk_intram has its use to be tested on board
without SDRAM and there are many other smaller variants
of TMS570 MCUs which are suitable for RTEMS in future but
again these are without external bus interface.

Best wishes,

             Pavel