feedback on Re: [PATCH v3] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

[Sebastian Huber]

On 20/08/14 20:17, Joel Sherrill wrote:
> Hi
>
> Initial quick feedback.  I build normally with --enable-rtems-debug
> and the tms570ls3137_hdk variant failed to build with this
> failure:
>
> arm-rtems4.11-gcc --pipe -DHAVE_CONFIG_H   -I../../..
> -I../../../../cpukit/../../../tms570ls3137_hdk/lib/include  -DASM
> -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG -Wall
> -Wmissing-prototypes -Wimplicit-function-declaration -Wstrict-prototypes
> -Wnested-externs -march=armv7-r -mthumb -mbig-endian -O2 -ggdb3 -DNDEBUG

Why do we have this -ggdb3 -NDEBUG set?

> -Wall -Wmissing-prototypes -Wimplicit-function-declaration
> -Wstrict-prototypes -Wnested-externs -MT
> libscorecpu_a-arm-context-volatile-clobber.o -MD -MP -MF
> .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo -c -o
> libscorecpu_a-arm-context-volatile-clobber.o `test -f
> 'arm-context-volatile-clobber.S' || echo
> '../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/'`arm-context-volatile-clobber.S
> mv -f .deps/libscorecpu_a-arm-context-volatile-clobber.Tpo
> .deps/libscorecpu_a-arm-context-volatile-clobber.Po
> In file included from
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/percpu.h:25:0,
>                   from
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/system.h:23,
>                   from
> ../../../../../../../../rtems/c/src/../../cpukit/score/cpu/arm/cpu.c:29:
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/isrlock.h:
> In function '_ISR_lock_ISR_disable_and_acquire':
> ../../../../cpukit/../../../tms570ls3137_hdk/lib/include/rtems/score/assert.h:38:46:
> error: '__ASSERT_FUNC' undeclared (first use in this function)
>             __assert_func( __FILE__, __LINE__, __ASSERT_FUNC, #_e ) )

It seems <rtems/score/assert.h> is broken in case NDEBUG is defined.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.