Add an --enable-httpd-websocket configure option to enable WebSocket in the Mongoose HTTP server

Nick Withers nick.withers at anu.edu.au
Mon Dec 15 02:32:45 UTC 2014


On Thu, 2014-12-11 at 08:25 +0100, Sebastian Huber wrote:
> Hello Nick,
> 
> this looks good, except that
> 
> On 10/12/14 06:05, Nick Withers wrote:
> > +  for (pos = response; response + sizeof (response) - pos && (size = read(ctx->socket, pos, response + sizeof (response) - pos)) > 0; pos += size)
> > +    ;
> 
> this line is too long and complex.  It appears also multiple times. 
> Maybe use a function for this.  It would be nice if you can use a line 
> limit of 79 chars.

Sorry - I should know better.

How's the attached?

P.S.: I also sprayed come consts around
-- 
Nick Withers

Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mghttpd-WebSocket.patch
Type: text/x-patch
Size: 9721 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/devel/attachments/20141215/042b1b72/attachment-0001.bin>


More information about the devel mailing list