Add an --enable-httpd-websocket configure option to enable WebSocket in the Mongoose HTTP server

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Dec 11 07:25:34 UTC 2014


Hello Nick,

this looks good, except that

On 10/12/14 06:05, Nick Withers wrote:
> +  for (pos = response; response + sizeof (response) - pos && (size = read(ctx->socket, pos, response + sizeof (response) - pos)) > 0; pos += size)
> +    ;

this line is too long and complex.  It appears also multiple times. 
Maybe use a function for this.  It would be nice if you can use a line 
limit of 79 chars.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list