[PATCH] Fixed errors check in mpc5200_psc_interrupt_handler()

[Sebastian Huber]

Hello Aleksandr,

On 2014-02-04 15:22, Aleksandr Platonov wrote:
> Hi.
>
>   - We should check error bits in psc->sr_csr (not in psc->isr_imr)
>   - SR_ERROR should also contains SR_RB bit
>
> P.S. Changes were made according with linux code
> (http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/tty/serial/mpc52xx_uart.c
> function mpc52xx_uart_int_rx_chars()) and MPC5200b user's manual (chapter
> 15.2.2.3))

there are some other problems in this area.  We have

/* Used to handle more than one channel */
struct per_channel_info channel_info[NUM_PORTS];

but the structure is defined in the source file.  So nobody except a debugger 
can read these values properly even though this is a global variable.

Maybe we should remove this stuff completely?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.