Posix patchs to support affinity attribute in newlib

[Jennifer Averett]

> -----Original Message-----
> From: rtems-devel-bounces at rtems.org [mailto:rtems-devel-
> bounces at rtems.org] On Behalf Of Sebastian Huber
> Sent: Friday, February 28, 2014 1:12 AM
> To: rtems-devel at rtems.org
> Subject: Re: Posix patchs to support affinity attribute in newlib
> 
> On 2014-02-27 14:24, Jennifer Averett wrote:
> >   /**
> > + * @brief Copy POSIX Thread attribute structure
> > + *
> > + * This routine copies the attr2 thread attribute structure
> > + * to the attr1 Thread Attribute structure.
> > + *
> > + * @param[out] attr1 is a pointer to the thread attribute
> > + * structure to copy into.
> > + *
> > + * @param[out] attr2 is a pointer to the thread attribute
> 
> Should be @param[in].
> 
> Why not name this src_attr and dst_attr or something similar?

Will change.

 
> > + * structure to copy from.
> > + */
> > +RTEMS_INLINE_ROUTINE void _POSIX_Threads_Copy_attributes(
> > +  pthread_attr_t  *attr1,
> > +  const pthread_attr_t  *attr2
> > +);
> > +
> 
> Why do we have the definition of this inline function separated from the
> declaration?
> 


This follows the structure of the file.  All other inline methods in this file
are defined in that manner.

> --
> Sebastian Huber, embedded brains GmbH
> 
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
> 
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
> _______________________________________________
> rtems-devel mailing list
> rtems-devel at rtems.org
> http://www.rtems.org/mailman/listinfo/rtems-devel