libbsp/powerpc/shared/motorola/vpd.c: Why is the _System_state_Is_up() path disabled?

Nick Withers nick.withers at anu.edu.au
Wed Jan 29 23:56:00 UTC 2014


Hi all,

Anyone have any idea why the "_System_state_Is_up(_System_state_Get())"
check in libbsp/powerpc/shared/motorola/vpd.c's BSP_vpdRetrieveFields()
is disabled with an (0 && _System_state_Is_up(_System_state_Get())?

I use the following and haven't observed any troubles (it mis-reads
otherwise):
____

diff --git a/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c b/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
index 4b0bbef..1cbfebc 100644
--- a/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
+++ b/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
@@ -137,7 +137,7 @@ static int    (*stop)(int fd);
 
        memset(mot,0,sizeof(mot));
 
-       if ( 0 && _System_state_Is_up(_System_state_Get()) ) {
+       if ( _System_state_Is_up(_System_state_Get()) ) {
                read_bytes = read;
                stop       = close;
                fd         = open(BSP_I2C_VPD_EEPROM_DEV_NAME, 0);
____
-- 
Nick Withers

Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)




More information about the devel mailing list