libbsp/powerpc/shared/motorola/vpd.c: Why is the _System_state_Is_up() path disabled?

[Nick Withers]

On Thu, 2014-01-30 at 09:08 -0800, Till Straumann wrote:
> I believe this is my code and it has been disabled forever.
> IIRC it is because even if the system is up the code can't
> know that there is a filesystem and that the i2c drivers
> are loaded and special device files created etc.

That makes a lot of sense - cheers Till!

> On 01/29/2014 03:56 PM, Nick Withers wrote:
> > Hi all,
> >
> > Anyone have any idea why the "_System_state_Is_up(_System_state_Get())"
> > check in libbsp/powerpc/shared/motorola/vpd.c's BSP_vpdRetrieveFields()
> > is disabled with an (0 && _System_state_Is_up(_System_state_Get())?
> >
> > I use the following and haven't observed any troubles (it mis-reads
> > otherwise):
> > ____
> >
> > diff --git a/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c b/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
> > index 4b0bbef..1cbfebc 100644
> > --- a/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
> > +++ b/c/src/lib/libbsp/powerpc/shared/motorola/vpd.c
> > @@ -137,7 +137,7 @@ static int    (*stop)(int fd);
> >   
> >          memset(mot,0,sizeof(mot));
> >   
> > -       if ( 0 && _System_state_Is_up(_System_state_Get()) ) {
> > +       if ( _System_state_Is_up(_System_state_Get()) ) {
> >                  read_bytes = read;
> >                  stop       = close;
> >                  fd         = open(BSP_I2C_VPD_EEPROM_DEV_NAME, 0);
> > ____
-- 
Nick Withers

Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)