Remaining arch issue in Newlib optimized ARM ASM memchr for Cortex-R

[Joel Sherrill]

On 7/3/2014 7:49 AM, Richard Earnshaw wrote:
> On 03/07/14 13:17, Nicholas Clifton wrote:
>> Hi Jeff,
>>
>>  >  Pavel Pisa wrote:
>>> Index: newlib-2.1/newlib/libc/machine/arm/memchr.S
>>> ===================================================================
>>> --- newlib-2.1.orig/newlib/libc/machine/arm/memchr.S    2011-10-18 13:35:17.000000000 +0200
>>> +++ newlib-2.1/newlib/libc/machine/arm/memchr.S 2014-07-03 00:38:47.598049234 +0200
>>> @@ -46,7 +46,11 @@
>>>   @    tidy
>>>
>>>          .syntax unified
>>> +#ifdef __ARM_ARCH_7R__
>>> +       .arch armv7-r
>>> +#else
>>>          .arch armv7-a
>>> +#endif
>>>
>>>   #include "arm_asm.h"
>> This patch looks good to me.
>>
>> Cheers
>>    Nick
>>
>>
>>
>
> Not quite.  It's better than what's already there, but misses the
> ARMv6t2 case -- see a couple of lines later.  I think a simple change to
>
> 	.arch armv6t2
>
> should handle all v7-a and v7-r cases.
I think it also is missing a ChangeLog entry.

Please update this Pavel.

Thanks.
> R.
>

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985