[PATCH] shell: Add rtems_shell_dup_current_env to get a default env.

Chris Johns chrisj at rtems.org
Wed Jun 4 10:55:41 UTC 2014

On 4/06/2014 4:28 pm, Sebastian Huber wrote:
> On 2014-05-29 07:10, Chris Johns wrote:
>> Remove rtems_current_shell_env as this is dangerous because
>> the env can be NULL if used outside of a valid shell with the
>> POSIX key to an env set up.
>> Clean up the usage of rtems_current_shell_env.
> The cleanup looks good, but we should keep the rtems_global_shell_env.
> I underestimated its widespread use, so it was an error that we removed
> it.  Now it is a constant, so you can use it only for the initialization
> with default values.

I would rather this API cleaned up and only a single way for 
applications to do this. It is a simple and clean change.

The change I have uses the environment of a caller if the caller has a 
specific environment in the key else the base it used, ie inherits the 
environment if present.


More information about the devel mailing list