[rtems commit] POSIX keys now enabled in all configurations.

[Sebastian Huber]

On 2014-03-11 13:35, Joel Sherrill wrote:
>  > > +    /**
>  > > +     * wait for test thread set key, the while loop here is used to
>  > > +     * avoid suprious wakeup.
>  > > +     */
>  > > +    while( created_thread_count > setted_thread_count )
>  > > +      pthread_cond_wait( &set_condition_var, &mutex1 );
>  > > +    pthread_mutex_unlock( &mutex1 );
>  > > +  }
>  > > +  printf(
>  > > +    "Init - %d pthreads have been created - OK\n"
>  > > +    "Init - %d pthreads have been setted key data - OK\n",
>  > > +    created_thread_count,
>  > > +    setted_thread_count
>  > > +  );
>  > >     rtems_test_assert( created_thread_count == setted_thread_count );
>  >
>  > Why did you convert this test to Classic API tasks?  It uses POSIX condition
>  > variables and mutexes.  I would change it back.
>
> If this test serves any useful purpose for covering POSIX key code, then it
> must be building and executable when POSIX threads are disabled.
>
> Thus if we are to fully test keys with POSIX disabled, all key tests had to
> become Classic API tests.
>

This test uses POSIX condition variables.  Also in the Makefile.am:

## But some of the tests need other POSIX features
if HAS_POSIX
SUBDIRS += psxkey07
endif

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.