[PATCH 1/2] Changed console driver to use interrupts instead of polling. Change to avoid overwriting CPU32Bug interrupt vector when setting up the Sci interrupt handler. Fixed type for boolean flag in bsp.h. Changed mrm332.h to use 25Mhz clock. Fixes to mrm332.cfg to use correct mcpu32 value for RTEMS_CPU_MODEL instead of m68332 which is no longer supported. Added -mcpu=cpu32 to compiler options. Removed broken ROM linker script and replaced broken RAM linker script with working ROM linker script. Removed no longer required file except_vect_332_ROM.S. Enabled 0xbeefbeef magic string in start.S to allow MRM version of CPU32Bug to auto run RTEMS. Removed old code from start.S

[James Fitzsimons]

Hi Gedare,

On 20 March 2014 04:48, Gedare Bloom <gedare at rtems.org> wrote:

> Hi James,
>
> Thanks for the patches! I have a couple of comments.
>
> First, the commit message for this patch should be divided into two
> pieces, a short message on the first line, and then a blank line, and
> then a longer detailed explanation. This way, the email subject and
> the log will be much easier to read.
>

Can do - that was my first attempt at using git send-email and it didn't
turn out quite how I expected!


> Comments about the patch in particular are inline below. Most of these
> are style nits that are advised but not required. We don't normally
> apply the same rigor to BSPs as to the rest of RTEMS, but appreciate
> if you do. :)


Of course, no problem. I should have checked for a style guide before I
submitted my patch.

I'll make the appropriate revisions and submit a revised patch in a few
days as I'm about to head off for a short break.

Cheers,
James
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20140320/781e2ce5/attachment-0001.html>