[RSB] possible bug - zip extracting

[Hesham Moustafa]

On Mon, May 12, 2014 at 6:54 AM, Chris Johns <chrisj at rtems.org> wrote:

> On 9/05/2014 11:40 am, Chris Johns wrote:
>
>> On 9/05/2014 5:02 am, Hesham Moustafa wrote:
>>
>>>
>>> When I replaced __zip with __unzip (in the previous file) I got the
>>> following error:
>>> "/bin/tar: This does not look like a tar archive"
>>>
>>> It seems like source-builder/sb/build.py (at line 155) always passes
>>> along the extracted file to "| %{__tar_extract}" even it was .zip
>>> file.
>>>
>>>
>> This is a bug.
>>
>> Please make a commit on your repo and post a link. I will review and
>> cherry pick into the master repo when ready.
>>
>>
> I will fix this. I am reworking the source and patch handling to remove
> the numbering allowing any number of patches without manually needing to
> manage the numbering. The code mentioned here is part of this rework.
>
> Sorry for my late response, I am busy with exams currently. Anyway, I have
managed to pass this with "if" statement checking if the macro is __unzip
or not, and according to that, the code adds | %{__tar_extract}" or not.

> Chris
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20140512/8a00f21a/attachment.html>