[PATCH 10/12] cpukit/sapi: Resources for bdbuf SMP workaround

Chris Johns chrisj at rtems.org
Tue May 27 23:39:04 UTC 2014

On 28/05/2014 12:48 am, Ralf Kirchner wrote:
> Enabling and disabling preemption as done for single core in bdbuf will not work for SMP.

Correct. Do the bdbuf tests currently fail on SMP ?

> Thus as a temporary workaround

If this is a workaround what do you see is the proper fix ?

> use POSIX mutexes and POSIX condition variables for SMP instead of the combination of semaphores and preemption handling used for single core.

I question this being conditional on SMP. Why not make it the same for 
both builds of RTEMS ? I have no problem with POSIX condition variables 
being used as the current method is a poor hacked version (done by me) 
and should be removed. Is doing a suitable "proper fix" ?

I would rather see us have a single method used for this code and it be 
tested and run as much as possible than see the code fragment in this way.

> These will be allocated automatically.

On the topic of automatic maybe POSIX defaults to on and if disabled 
this code is not built. I do not think we need more POSIX enable work 


More information about the devel mailing list