[RSB] possible bug - zip extracting

[Chris Johns]

On 9/05/2014 5:02 am, Hesham Moustafa wrote:
> Hi,
>
> When I was trying to add a package to be built from RSB, I came a
> cross an error. The package is downloaded as *.zip file. The error I
> got when extracting the package is (quoted from the log file):
>
> "prep: or1ksim: %setup -q -n or32-master
> making dir: /run/media/hesham/2cdb13e0-83ac-4ebd-9ead-be52de50707c/home/hesham/RTEMS/rsb/bare/config/devel/sources
> script: 72: cd /run/media/hesham/2cdb13e0-83ac-4ebd-9ead-be52de50707c/home/hesham/RTEMS/rsb/bare/config/devel/build/or1ksim
> script: 73: /bin/rm -rf or32-master
> error: or1ksim-git.cfg:0: macro '%{__zip}' not found
> error: or1ksim-git.cfg:0: macro '%{__zip}' not found
> error: or1ksim-git.cfg:0: macro '%{__zip}' not found
> script: 74: %{__zip} -u
> /run/media/hesham/2cdb13e0-83ac-4ebd-9ead-be52de50707c/home/hesham/RTEMS/rsb/bare/config/devel/sources/or32-master.zip
> | /bin/tar -xvvf -
> script: 75: cd or32-master"
>
> There is no macro with name "__zip", the command causing this error is
> at source-builder/sb/download.py:47

This means it needs to be added to defaults.mc (use /usr/bin/unzip) and 
overridden in each host specific configuration file that differs. I 
think __unzip should be added and used and not __zip.

>
> When I replaced __zip with __unzip (in the previous file) I got the
> following error:
> "/bin/tar: This does not look like a tar archive"
>
> It seems like source-builder/sb/build.py (at line 155) always passes
> along the extracted file to "| %{__tar_extract}" even it was .zip
> file.
>

This is a bug.

Please make a commit on your repo and post a link. I will review and 
cherry pick into the master repo when ready.

Thanks
Chris