[PATCH] libbsp ARM: create abort.h to eliminate warnings Created libbsp/arm/shared/abort/abort.h Edited abort.c and simple_abort.c to include abort.h Changed Raspberry Pi BSP to use abort.c instead of simple_abort.c

[Sebastian Huber]

On 08/11/14 18:04, Gedare Bloom wrote:
> On Sat, Nov 8, 2014 at 11:50 AM, Alan Cudmore<alan.cudmore at gmail.com>  wrote:
>> >On 11/5/2014 9:39 AM, Sebastian Huber wrote:
>>> >>
>>> >>On 05/11/14 15:35, Alan Cudmore wrote:
>>>> >>>
>>>> >>>If the ARM BSPs that do not use the shared start.S include the code, but
>>>> >>>never
>>>> >>>call it, I can remove it, if that is what is best. We could even remove
>>>> >>>abort.c
>>>> >>>and simple_abort.c completely. Just let me know.
>>> >>
>>> >>
>>> >>It would be best to get rid of these files.
>>> >>
>> >I did some investigation, and it is not going to be as easy as I thought to
>> >remove libbsp/arm/shared/abort/*.c
>> >
>> >The following ARM BSPs use score: arm_exc_handler_high.c,
>> >arm_exc_handler_low.S, which in turn use shared abort.c ( or simple_abort.c
>> >):
>> >  csb336,
>> >  csb337,
>> >  edb7312,
>> >  gp32,
>> >  gumstix,
>> >  rtx22xx
>> >
>> >I think these will eventually have to be converted to use the ARM shared
>> >start.S.
>> >
> Thanks for chasing this down. We should open a bug on this when we can.
>
>> >The raspberrypi, beagle, and gdbarmsim BSPs compile the shared/abort files
>> >but do not use them.
>> >
>> >So for now I can do the following:
>> >1. remove the use of shared/abort/abort*.c from raspberrypi, beagle, and
>> >gdbarmsim ( in Makefile.am )
>> >2. include a header file in shared/abort to eliminate future warnings for
>> >BSPs that use abort.c simple_abort.c
>> >
> Ok
>

Yes, this sounds good.  Converting the BSPs to use the shared.S could turn out 
to be a bit time consuming.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.