[PATCH 1/3] smpschedaffinity02: Change semaphore attributes.

Daniel Hellstrom daniel at gaisler.com
Wed Nov 19 15:29:10 UTC 2014


Hello,

All three patches have whitespace on "RTEMS_PRIORITY | " below. Otherwise it looks good.

Thanks!


On 11/13/2014 07:15 PM, Jennifer Averett wrote:
> Change semaphore attributes to prevent semaphore from being
> locked and never released upon a context switch.
> ---
>   testsuites/smptests/smpschedaffinity02/init.c | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/testsuites/smptests/smpschedaffinity02/init.c b/testsuites/smptests/smpschedaffinity02/init.c
> index a3e0ddf..5f22110 100644
> --- a/testsuites/smptests/smpschedaffinity02/init.c
> +++ b/testsuites/smptests/smpschedaffinity02/init.c
> @@ -115,6 +115,7 @@ static void task(rtems_task_argument arg)
>       if (sc == RTEMS_SUCCESSFUL) {
>         task_data.actual_cpu = rtems_get_current_processor();
>         task_data.ran = true;
> +      test_delay(25);
>         rtems_semaphore_release(task_sem);
>       }
>     }
> @@ -140,11 +141,9 @@ static void test(void)
>     sc = rtems_semaphore_create(
>       rtems_build_name('S', 'E', 'M', '0'),
>       1,
> -    RTEMS_LOCAL                   |
> -    RTEMS_SIMPLE_BINARY_SEMAPHORE |
> -    RTEMS_NO_INHERIT_PRIORITY     |
> -    RTEMS_NO_PRIORITY_CEILING     |
> -    RTEMS_FIFO,
> +    RTEMS_BINARY_SEMAPHORE |
> +    RTEMS_PRIORITY |

on this line

> +    RTEMS_PRIORITY_CEILING,
>       0,
>       &task_sem
>     );




More information about the devel mailing list