[PATCH 09/20] dosfs/msdos_conv.c: Remove unnecessary operations

Joel Sherrill joel.sherrill at oarcorp.com
Tue Nov 25 23:02:37 UTC 2014


From: Josh Oguin <josh.oguin at oarcorp.com>

These were flagged by CodeSonar. The assignments on variable declaration
are overridden a few lines below and the other line later with name_size
is where name_size was not used after this assignment.
---
 cpukit/libfs/src/dosfs/msdos_conv.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/cpukit/libfs/src/dosfs/msdos_conv.c b/cpukit/libfs/src/dosfs/msdos_conv.c
index b391717..98f2e9b 100644
--- a/cpukit/libfs/src/dosfs/msdos_conv.c
+++ b/cpukit/libfs/src/dosfs/msdos_conv.c
@@ -409,8 +409,8 @@ msdos_filename_utf8_to_long_name_for_save (
 {
     ssize_t      returned_size = 0;
     int          eno           = 0;
-    size_t       name_size     = utf8_name_size;
-    size_t       name_size_tmp = long_name_size / MSDOS_NAME_LFN_BYTES_PER_CHAR;
+    size_t       name_size;
+    size_t       name_size_tmp;
     int          i;
     uint16_t     c;
     unsigned int chars_written;
@@ -452,7 +452,6 @@ msdos_filename_utf8_to_long_name_for_save (
         if ( name_size == UTF16_NULL_SIZE && c == UTF16_NULL ) {
           long_name[i]   = c;
           returned_size += MSDOS_NAME_LFN_BYTES_PER_CHAR;
-          name_size     -= MSDOS_NAME_LFN_BYTES_PER_CHAR;
         }
         else if ( name_size != 0 )
           eno = EINVAL;
-- 
1.9.3




More information about the devel mailing list